Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): add missing validation rules for v1beta1 #677

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Feb 6, 2025

Description

Duplicate missing validation rules from v1 into v1beta1 API

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added the area/api-validation Issues or PRs related to API validation label Feb 6, 2025
matthchr
matthchr previously approved these changes Feb 6, 2025
Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

@tallaxes
Copy link
Collaborator Author

tallaxes commented Feb 6, 2025

#678 to fix vulncheck

@tallaxes tallaxes requested a review from matthchr February 6, 2025 22:35
@tallaxes tallaxes merged commit ea76305 into main Feb 7, 2025
11 checks passed
@tallaxes tallaxes deleted the tallaxes/validation-rules-for-v1beta1 branch February 7, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-validation Issues or PRs related to API validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants